RSDK-13626: Remove getImage, Format helpers, and format field usage#149
Open
RSDK-13626: Remove getImage, Format helpers, and format field usage#149
Conversation
Pre-emptive removal ahead of viamrobotics/api#758 which deletes GetImage, RenderFrame, and the Format enum from camera.proto. Removes: - getImage abstract method and mimeToFormat/formatToMime from Camera.java - getImage implementation from CameraRPCClient.java - getImage handler and deleted type imports from CameraRPCService.java - Format import from Media.kt; switches Image.dimensions to use mimeType Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
👋 Thanks for requesting a review from the team! We aim to review PRs within one business day. If this is urgent |
hexbabe
commented
Mar 18, 2026
| val Image.dimensions: ImageDimensions? | ||
| get() = try { | ||
| getDimensions(this.image, this.format.name) | ||
| getDimensions(this.image, this.mimeType) |
Member
Author
There was a problem hiding this comment.
does anything important rely on this? I don't think we should support this anymore
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getImageabstract method andmimeToFormat/formatToMimefromCamera.javagetImage()implementation fromCameraRPCClient.javagetImage()handler andGetImageRequest/GetImageResponseimports fromCameraRPCService.javaFormatimport fromMedia.kt; switchImage.dimensionsto usemimeTypeinstead offormat.namePre-emptive cleanup ahead of viamrobotics/api#758 which deletes
GetImage,RenderFrame, and theFormatenum fromcamera.proto. The Java SDK had the deepest usage of these deleted types, including real business logic in the RPC client/service and theMedia.ktutility.Test plan
🤖 Generated with Claude Code