Closed
Conversation
The unlabeled event caused transient failures when compile_protos removed the protos-compiled label before re-adding it after compilation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abe-winter
added
the
ready-for-protos
This label triggers compile_protos which will add protos-compiled later, so running the merge check at this point would always fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
not needed actually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
unlabeledeventWhy
In
ready-for-protosmode, subsequent commits to a PR will remove the label at the top of the PR, triggering a check merge reqs run which will fail because the desired label isn't present. (Because it was just removed).This PR fixes that by only running the check at the bottom, when the label is added.
In workflows where the user only sets
ready-for-protosat the end of the PR when no more changes are needed, this doesn't happen because there are no more commits after the label is set, so the bug took a while to poke its head up.Follow-up work
The downside of this is that the check merge reqs job will remain present and allow people to merge even if they make subsequent non-proto-compiled changes to their PR.