[APP-15326] Add config_json to RobotPart and UpdateRobotPartRequest#821
Open
[APP-15326] Add config_json to RobotPart and UpdateRobotPartRequest#821
Conversation
tgritter
changed the title
config_json to RobotPart and UpdateRobotPartRequest
tgritter
added
the
ready-for-protos
purplenicole730
approved these changes
Mar 12, 2026
edobranov
reviewed
Mar 13, 2026
proto/viam/app/v1/app.proto
Outdated
| optional google.protobuf.Timestamp last_known_update = 4; | ||
| // config_json is the raw JSON string of the robot config, preserving user-defined key order. | ||
| // When set, this takes precedence over robot_config for storage purposes. | ||
| string config_json = 5; |
Member
There was a problem hiding this comment.
Suggested change
| string config_json = 5; | |
| optional string robot_config_json = 5; |
Couple things:
- Prefix with
robot_to align it with the related protobuf struct name. - I think this should be optional based on the "when set" phrase? I think that's more idiomatic for protos than handling it as an empty string.
tgritter
force-pushed
the
APP-15326/robot-config-json-field-order
branch
from
9f3ebc7 to
6dc6090
Compare
tgritter
force-pushed
the
APP-15326/robot-config-json-field-order
branch
from
775cb54 to
eb55464
Compare
tgritter
force-pushed
the
APP-15326/robot-config-json-field-order
branch
from
0626bf9 to
070d0f6
Compare
tgritter
added
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
config_jsonfield toRobotPartandUpdateRobotPartRequestto support preserving user-defined JSON field ordering in machine configs. BSON does not guarantee map key order on read-back, so the app layer uses this field to store and return the raw JSON exactly as written.Links