Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use native sample rate for microphone input when supported
Previously the microphone always opened the PortAudio stream at the device's default sample rate, regardless what was configured. If the user requested a different rate (e.g. 16kHz), audio was captured at the device default (e.g. 44.1kHz) and resampled — even if the device natively supported 16kHz.
This PR uses Pa_IsFormatSupported to check whether the requested sample rate is natively supported before opening the stream. If it is, the stream is opened at the requested rate directly, avoiding unnecessary resampling. If not, it falls back to the device default and resamples as before.
1 approval