Skip to content

remove unnecessary return info#4889

Merged
adamnovak merged 1 commit intomasterfrom
simplify-return
Apr 28, 2026
Merged

remove unnecessary return info#4889
adamnovak merged 1 commit intomasterfrom
simplify-return

Conversation

@faithokamoto
Copy link
Copy Markdown
Contributor

Changelog Entry

To be copied to the draft changelog by merger:

  • Simplify an internal return value for align_sequence_between()

Description

I saw a TODO and thought I could tackle it for kicks. Indeed, while align_sequence_between()/align_sequence_between_consistently() used to return a pair of values, the only thing we actually ever used those return values for was checking whether the first was nonzero or not. So now I simply have it return whether that first value would have been zero. Makes it easier to interpret. Also possibly saves a negligible amount of overhead that would have been spent constructing the pair.

@faithokamoto
Copy link
Copy Markdown
Contributor Author

Mac failed with Could not resolve host: raw.githubusercontent.com when I think it was trying to download something. @adamnovak do I just re-run or is there something I should fix?

Copy link
Copy Markdown
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good simplification.

@adamnovak
Copy link
Copy Markdown
Member

I don't think there's anything to fix; our test runners sometimes inexplicably cannot talk to the Internet. I'm hoping this will go away when OpenStack is destroyed in June and I'm forced to migrate them to live somewhere else; I don't think the underlying problem is systemd/systemd#32045 because the networking comes back and I don't remember setting up any watchdog stuff on the Gitlab runners.

@adamnovak adamnovak merged commit 53ab106 into master Apr 28, 2026
2 of 3 checks passed
@faithokamoto faithokamoto deleted the simplify-return branch April 28, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants