Breath code refactoring#39263
Conversation
|
Mr shreshident another refactor has hit the twin repos |
necessary evil for if someone wants to try the co2 PR again but with fairer balance, or even sanitize lung popping which is my idea going forward. |
|
fixed the logic, can't respond to that review for some reason |
|
gonna be straight with u this is an important refactor that needs to happen but its also very fragile tldr gonna stay unmerged for a bit longer until i scrape together time, hopefully next week some point |
not even gonna attempt to review |
dont even need to read it to updoot |
[cleanup]
What this does
Makes these files easier to work with, moves relevant code from species into lung gas datums.
Splits off parts of breath() on carbons into separate functions such as check_breath_block() and needs_to_breathe() for modularity and less code reuse.
Why it's good
Easier maintenance for someone who wants to fix or tweak it.
How it was tested
Entering cryotubes, shelters, and wearing a plastic bag on head as a human, calling needs_to_breathe() and check_breath_block() (with a gas mask on) on humans and monkeys, immersing them in a normal room, then opening canisters of plasma and n2o, then spacewalking as each.
Changelog
No user facing changelog.