Fix socket binding on macOS/BSD#19
Open
ortix wants to merge 1 commit into
Open
Conversation
- Prioritize IPV6_BOUND_IF/IP_BOUND_IF over SO_BINDTODEVICE for macOS/BSD compatibility - Use portable ifr_name instead of Linux-specific ifr_ifrn.ifrn_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes socket binding issues that prevent compilation and correct operation on modern macOS versions.
Changes
Prioritize
IPV6_BOUND_IF/IP_BOUND_IFoverSO_BINDTODEVICE: On macOS/BSD, the native APIs for binding sockets to specific interfaces areIP_BOUND_IFandIPV6_BOUND_IF. The previous#if/#elifordering caused theSO_BINDTODEVICEpath (which doesn't work on macOS) to be selected.Use portable
ifr_nameinstead ofifr_ifrn.ifrn_name: Theifr_ifrn.ifrn_namemember is Linux-specific. The standard portable way to access the interface name instruct ifreqis viaifr_name, which works on all POSIX platforms.Testing
Verified that the code compiles and runs correctly on macOS (Tahoe). The changes are backwards-compatible and do not affect Linux behavior since
SO_BINDTODEVICEis still used when available.Notes
This is a non-breaking fix that improves cross-platform compatibility.