chore: de-privatize for public release#13
Conversation
ARCHITECTURE_ACTUAL/COMPARISON/PROMISED are internal session-audit artifacts (deployment topology, launchd labels, host paths, status snapshots) not meant for a public release. Not referenced anywhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
De-privatization pass to make the repo read as a neutral tool: - Brand: camelCase 'VetCoders' -> 'Vetcoders' (prose) / 'vetcoders' (URLs, repo slugs, project ids); standardize credit line. - People: collapse 'Maciej'/'Klaudiusz'/'M&K' + personal emails to 'Vetcoders <hello@vetcoders.io>'; drop 'The LibraxisAI Team'. - Infra: launchd label 'ai.libraxis.*' -> 'com.vetcoders.*'; default data dir '~/.ai-memories/*' -> '~/.rmcp-servers/rmcp-memex/*'; '/Volumes/LibraxisShare/*' example paths neutralized. - Machines: example/prose 'dragon'/'mgbook16' -> 'host-a'/'host-b' (functional embedder host identity in src/embeddings + config left as-is; see needs_decision in PR notes). - Namespaces: private 'kb:mikserka' -> 'kb:notes' (incl. tests). - Tests: replace real home path + realistic Polish transcript fixture with neutral equivalents; assertions updated in lockstep. Product names (memex/rmcp/lancedb) preserved. 'vista' codename left untouched (needs_decision: leaks private PIMS product + domain). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request focuses on rebranding, path standardization, and documentation cleanup across the repository. Key changes include updating the organization name casing from 'VetCoders' to 'Vetcoders' in copyright notices, repository URLs, and documentation, as well as migrating default database and log paths from ~/.ai-memories/ to ~/.rmcp-servers/rmcp-memex/. Additionally, hostnames, volume names, and namespaces in examples, tests, and documentation have been generalized (e.g., replacing 'dragon' with 'host-a' and 'mikserka' with 'notes'), and several architecture documentation files have been removed. As there are no review comments to assess, I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Scrubs private/internal context from the repo to prepare a neutral public release surface, including removing internal deployment/audit docs and normalizing branding/paths/fixtures.
Changes:
- Replaced internal brand/owner strings and GitHub org casing in docs, headers, metadata, and URLs.
- Updated default/local paths and examples from
~/.ai-memories/...to~/.rmcp-servers/rmcp-memex/..., plus neutralized host/namespace fixture values in tests. - Removed internal architecture audit documents (
docs/ARCHITECTURE_{ACTUAL,COMPARISON,PROMISED}.md).
Reviewed changes
Copilot reviewed 40 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/transport_parity.rs | Updates brand string in test header comment. |
| tests/e2e_pipeline.rs | Updates brand string in test header comment. |
| tests/auth_tokens.rs | Neutralizes namespace/token fixture values (kb:notes) and migration assertions. |
| src/tui/app.rs | Changes default DB path and example paths to the new canonical location. |
| src/search/hybrid.rs | Updates test fixture project_id branding. |
| src/rag/structured.rs | Neutralizes embedded project metadata fixture slug casing. |
| src/rag/mod.rs | Neutralizes path/transcript fixtures and project metadata slugs in tests. |
| src/query/router.rs | Neutralizes example/test query strings from private hostnames to host-a. |
| src/query/mod.rs | Neutralizes example query string in module docs. |
| src/http/mod.rs | Updates branding strings in module docs and embedded dashboard HTML footer. |
| src/engine.rs | Neutralizes doc examples from private hostnames to host-a. |
| src/bin/rmcp_memex.rs | Updates branding string in CLI entrypoint comment. |
| src/bin/cli/definition.rs | Neutralizes CLI help examples (queries, merge prefix, auth namespaces). |
| src/auth/mod.rs | Updates module header branding and test fixture namespaces. |
| SECURITY.md | Updates copyright comment and GitHub Security Advisories link casing/org. |
| scripts/release-local.sh | Updates default GitHub repo slug to lowercase org. |
| scripts/reindex-memories.sh | Updates default local paths + install URL; neutralizes “created by” attribution. |
| README.md | Updates badges/URLs, install commands, examples, and footer attribution for public surface. |
| Makefile | Updates launchd label/path + default local paths; neutralizes hardware/host wording. |
| LICENSE-APACHE | Updates copyright holder casing. |
| LICENSE | Updates copyright holder casing. |
| install.sh | Updates installer comments and hardcoded repo slug to lowercase org. |
| docs/RELEASE.md | Updates release verification URLs to lowercase org. |
| docs/INDEXING_GUIDE.md | Updates footer attribution branding. |
| docs/index.html | Updates GitHub links and install commands to lowercase org; branding text. |
| docs/HTTP_API.md | Updates header attribution branding. |
| docs/assets/social-card.svg | Updates social card description and repo URL casing. |
| docs/ARCHITECTURE_PROMISED.md | Removes internal architecture audit doc. |
| docs/ARCHITECTURE_COMPARISON.md | Removes internal architecture audit doc. |
| docs/ARCHITECTURE_ACTUAL.md | Removes internal architecture audit doc. |
| docs/02_configuration.md | Neutralizes example allowed_paths entry and footer attribution. |
| docs/01_security.md | Neutralizes example allowed_paths entry and footer attribution. |
| CONTRIBUTING.md | Updates copyright comment branding. |
| CHANGELOG.md | Updates example paths/URLs and branding. |
| Cargo.toml | Updates repository/homepage URLs to lowercase org. |
| ai-hooks/README.md | Updates default DB path and footer attribution branding. |
| ai-hooks/memex-startup.sh | Updates default DB path and “created by” attribution. |
| ai-hooks/memex-context.sh | Updates default DB path in comments/config and “created by” attribution. |
| .github/workflows/loctree-ci.yml | Replaces Co-Authored-By line with neutral org address. |
| .github/ISSUE_TEMPLATE/feature_request.yml | Updates copyright comment branding. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Updates copyright comment branding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The cfg'd early return for non-macOS targets makes the macOS ioreg telemetry body unreachable by design. CI's `clippy --all-targets -- -D warnings` on ubuntu-latest promotes `unreachable_code` to an error; macOS builds never compile the early return so the lint stayed hidden locally. Scope the allow to non-macOS so the gate is green cross-platform without dead-coding the macOS-only helpers. Pre-existing (untouched by the de-privatization scrub). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pre-public-release de-privatization
Context-leak scrub so the repo reads as a neutral tool, not a fragment of a
private project. Scanner:
vc-deprivatize(Layer A deterministic + Layer Bagent judgment). Auto-fixed unambiguous leaks; borderline calls left below for
maintainer decision.
Commits (2)
68d1096chore(deprivatize): remove internal architecture audit docsa9d64adchore(deprivatize): scrub private context from public surface41 files changed, +134/-747 (the deletions are 3 internal architecture-audit
docs that reconstructed a private deployment).
What was scrubbed
VetCoders→Vetcoders(prose/copyright) /vetcoders(URLs, repo slugs).void@…/the1st@…→Co-Authored-By: Vetcoders <hello@vetcoders.io>;Created by …→Created by vetcoders.ai.libraxis.*→com.vetcoders.*; default dir~/.ai-memories/*→ canonical~/.rmcp-servers/rmcp-memex/*;/Volumes/LibraxisShare/*→/Volumes/SharedDrive/*.dragon/mgbook16in prose/example-paths →host-a/host-b(functionaldragon_*identifiers left — see below).docs/ARCHITECTURE_{ACTUAL,COMPARISON,PROMISED}.md(internal session-audit: deployment topology, launchd PID dumps).needs_decision (NOT changed — maintainer call)
vista(44 occurrences) — private product name + domain in public API:MemexEngine::for_vista(),for_app("vista", …), README "Vista Integration". Renaming changes the API contract.dragonas functional embedder identity —DRAGON_BASE_URL/DRAGON_EMBEDDER_PORT,dragon_url/dragon_port, defaulthttp://dragon:12345. Renaming changes the env-var API + tests. Symbol-aware rename required (blanket replace breaks the build).Gates
vc-deprivatize verify→ exit 0 (no hard PII/secrets; residual = needs_decision above).cargo fmt --checkclean;cargo +1.95.0 check --all-targetsOK;cargo test --lib269 passed,--test auth_tokens11 passed.constant_time_eqneeds 1.95) — pre-existing, unrelated to this PR.Do not merge automatically — review the two
needs_decisionitems first.🤖 Generated with Claude Code