[codex/vc-release] release(pages): add manual dmg landing#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request redesigns the landing page (docs/index.html) for Pensieve, updating its layout, styling, and responsiveness. Feedback on the changes highlights a regression in dark mode support, suggesting the restoration of the dark mode media query and the use of the --panel CSS variable instead of a hardcoded background color. Additionally, it is recommended to use semantic <pre><code> tags instead of a <div> with <br /> for terminal commands.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| :root { | ||
| --paper: #f7f7f2; | ||
| --ink: #111312; | ||
| --muted: #5d625f; | ||
| --rule: #d7d8d1; | ||
| --panel: #ffffff; | ||
| --red: #b34132; | ||
| --blue: #2f6f91; | ||
| --green: #637b4f; | ||
| --shadow: 0 22px 60px rgba(17, 19, 18, 0.18); | ||
| } |
There was a problem hiding this comment.
The previous version of the landing page supported dark mode via @media (prefers-color-scheme: dark). The new design removes this support, which is a regression in user experience and accessibility for macOS users who prefer dark mode.
To restore dark mode support seamlessly with the new color palette, we can add a media query to override the CSS variables. Note that we should also update .proof-strip (line 234) to use var(--panel) instead of a hardcoded #ffffff.
:root {
--paper: #f7f7f2;
--ink: #111312;
--muted: #5d625f;
--rule: #d7d8d1;
--panel: #ffffff;
--red: #b34132;
--blue: #2f6f91;
--green: #637b4f;
--shadow: 0 22px 60px rgba(17, 19, 18, 0.18);
}
@media (prefers-color-scheme: dark) {
:root {
--paper: #151817;
--ink: #f8f8f4;
--muted: #8a8f8c;
--rule: #2e3230;
--panel: #1c1f1e;
--shadow: 0 22px 60px rgba(0, 0, 0, 0.5);
}
}| } | ||
|
|
||
| .proof-strip { | ||
| background: #ffffff; |
| <div class="source-command"> | ||
| git clone https://github.com/vetcoders/pensieve.git<br /> | ||
| cd pensieve && make run | ||
| </div> |
There was a problem hiding this comment.
Using a <div> with <br /> tags for terminal commands is non-semantic. Wrapping code and terminal commands in <pre><code> is the standard, semantically correct approach. It also improves accessibility (screen readers will announce it as a code block) and naturally preserves formatting without needing <br /> tags.
<pre class="source-command"><code>git clone https://github.com/vetcoders/pensieve.git
cd pensieve && make run</code></pre>3635ff9 to
5e2353b
Compare
Adds a GitHub Pages download surface for the locally notarized DMG release and vendors the release-profile qube-ffi dylib used by the shipped artifact. Authored-By: codex <agents@vetcoders.io> session_id: 019f524d-cc92-7473-83b6-cf3d8f16108c time: 2026-07-12T10:14:51+02:00 runtime: iterm2
5e2353b to
9f49221
Compare
Summary
releases/latest/download/Pensieve.dmg.libqube_ffi.dylibused by the shippedFFI_PROFILE=releasebuild.Why
This keeps the release lane manual and boring: local Developer ID signing, Apple notarization, stapling, then a manual GitHub Release asset upload. No release workflow YAML needed.
Verification
VISTA_KERNEL_ROOT=/Users/maciejgad/vc-workspace/LibraxisAI/vista-kernel FFI_PROFILE=release make release-cleancodesign --verify --deep --strict --verbose=2 dist/Pensieve.appxcrun stapler validate dist/Pensieve.appspctl --assess --type execute --verbose dist/Pensieve.appcodesign --verify --verbose=2 dist/Pensieve.dmgxcrun stapler validate dist/Pensieve.dmgspctl --assess --type open --context context:primary-signature --verbose dist/Pensieve.dmgsemgrep scan --config auto --error --quiet --exclude-rule html.security.audit.missing-integrity.missing-integrity .Release Artifact
Built locally at
dist/Pensieve.dmg, signed, notarized, stapled, and ready for manual GitHub Release upload.SHA-256:
272ab1dadf9f5ecf12d46c7a2d9f3de1f36f35a16cc6e3a44dacafcb00c8317d