Repository navigation
Conversation
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fixes #255
Description:
The ":repeat" command may silently skip the next nGQL statement when an invalid repeat count is provided.
The existing validation prints an error but still assigns the invalid value to "g_repeats".
For example:
As a result, the next nGQL statement is skipped because the execution loop does not run.
Additionally, the validation message contains a spelling mistake and incorrectly describes the minimum allowed value.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Reproduction
nebula> :repeat 0
Error: invalid integer, repeats should be greater than or equal to 1
nebula> SHOW HOSTS;
Before this fix, "SHOW HOSTS" is skipped. After the fix, invalid repeat counts no longer change "g_repeats", so the next statement executes normally.