Skip to content

chore: Update the vnetestbed with latest internal libs - #47

Open
ajeetsinghyadav wants to merge 7 commits into
mainfrom
VNE_TESTBED_DEPS_UPDATE
Open

ajeetsinghyadav wants to merge 7 commits into
mainfrom
VNE_TESTBED_DEPS_UPDATE

Conversation

@ajeetsinghyadav

@ajeetsinghyadav ajeetsinghyadav commented Aug 23, 2026 •

Copy link
Copy Markdown
Member

Description

Release notes: Use a Conventional Commits–style PR title (e.g. feat: add X, fix: resolve Y, docs: update Z) so release-please can include this change in the changelog. If you squash-merge, use the PR title as the commit message.

Checklist

  • Project builds (e.g. cmake -B build and cmake --build build, or platform script).
  • Tests pass (e.g. ctest --test-dir build or script -a test).
  • Code is formatted (e.g. run clang-format as configured for this repo); CI clang-format will check.
  • Docs updated if you changed behavior or public API.

Additional notes

Summary by CodeRabbit

  • New Features

    • Added text input event support for GLFW windows and ImGui.
    • Text entered through keyboards is now delivered as UTF-8 text, improving support for international characters.
    • The event demo displays the most recently received text input and clarifies the available input methods.
  • Bug Fixes

    • Replaced legacy key-typed handling with dedicated text input handling for more accurate character entry.

- Introduced handling for TextInputEvent in EventsLayer, allowing for text input capture.
- Updated ImGuiLayer to display the last text input event, enhancing user feedback.
- Modified README to reflect the new text input functionality in the demo.
- Replaced deprecated KeyTypedEvent with TextInputEvent in event listeners for better clarity and functionality.
@ajeetsinghyadav ajeetsinghyadav self-assigned this Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0da975fd-6d03-46c7-b425-4566029b294c

📥 Commits

Reviewing files that changed from the base of the PR and between 34dfed3 and 60226d6.

📒 Files selected for processing (14)
  • deps/internal/vnecommon
  • deps/internal/vneevents
  • deps/internal/vneinteraction
  • deps/internal/vneio
  • deps/internal/vnelogging
  • deps/internal/vnemath
  • deps/internal/vnescene
  • samples/glfw_opengl/01_test_events/README.md
  • samples/glfw_opengl/01_test_events/demo_test_events.cpp
  • samples/glfw_opengl/01_test_events/demo_test_events.h
  • src/vertexnova/testbed/app/application.cpp
  • src/vertexnova/testbed/imgui/imgui_event_listener.cpp
  • src/vertexnova/testbed/imgui/imgui_layer.cpp
  • src/vertexnova/testbed/window/glfw_window.cpp

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The testbed now uses UTF-8 TextInputEvent events from GLFW through application and ImGui listeners. The event sample records, logs, and displays received text input. Internal dependency references and sample documentation were updated.

Changes

Text Input Event Migration

Layer / File(s) Summary
Dependency reference updates
deps/internal/*
Seven internal submodule references now point to newer commits.
Text input event pipeline
src/vertexnova/testbed/window/glfw_window.cpp, src/vertexnova/testbed/app/application.cpp, src/vertexnova/testbed/imgui/*
GLFW converts codepoints to UTF-8 and emits TextInputEvent. Application and ImGui registration use eTextInput, and ImGui receives the event text.
Event sample display and documentation
samples/glfw_opengl/01_test_events/*
The sample records and displays the latest text input. The README documents text input testing separately from the ImGui character field.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 60226

This PR updates internal library revisions and related event-handling/sample code; no actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant GLFWWindow
  participant Application
  participant ImGuiEventListener
  participant ImGui
  GLFWWindow->>Application: Emit TextInputEvent with UTF-8 text
  Application->>ImGuiEventListener: Deliver eTextInput
  ImGuiEventListener->>ImGui: Forward UTF-8 text
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary dependency updates and matches the pull request objectives.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch VNE_TESTBED_DEPS_UPDATE

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant