Repository navigation
chore: Update the vnetestbed with latest internal libs - #47
ajeetsinghyadav wants to merge 7 commits into
Conversation
…oved compatibility
…mits with dirty state
- Introduced handling for TextInputEvent in EventsLayer, allowing for text input capture. - Updated ImGuiLayer to display the last text input event, enhancing user feedback. - Modified README to reflect the new text input functionality in the demo. - Replaced deprecated KeyTypedEvent with TextInputEvent in event listeners for better clarity and functionality.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe testbed now uses UTF-8 ChangesText Input Event Migration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates internal library revisions and related event-handling/sample code; no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant GLFWWindow
participant Application
participant ImGuiEventListener
participant ImGui
GLFWWindow->>Application: Emit TextInputEvent with UTF-8 text
Application->>ImGuiEventListener: Deliver eTextInput
ImGuiEventListener->>ImGui: Forward UTF-8 text
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Description
Release notes: Use a Conventional Commits–style PR title (e.g.
feat: add X,fix: resolve Y,docs: update Z) so release-please can include this change in the changelog. If you squash-merge, use the PR title as the commit message.Checklist
cmake -B buildandcmake --build build, or platform script).ctest --test-dir buildor script-a test).clang-formatas configured for this repo); CI clang-format will check.Additional notes
Summary by CodeRabbit
New Features
Bug Fixes