Repository navigation
fix: Updating the samples for vneinteraction fixes. - #39
Merged
ajeetsinghyadav merged 14 commits intoMar 30, 2026
Merged
Conversation
…ology - Updated the vneinteraction subproject to the latest commit. - Revised comments and documentation across multiple demo files to replace "orbit-arcball" with "orbit/trackball" for consistency. - Adjusted controller types and method names to reflect the new Inspect3DController, enhancing clarity in interaction handling.
…tion - Removed unused ortho_pan_zoom_behavior include and replaced references with ortho2DBehavior for consistency. - Updated method calls in InteractionTestLayer and InteractionSettingsLayer to align with the new behavior naming, enhancing clarity in interaction handling.
- Included the ortho_2d_behavior header to enhance interaction capabilities in the demo. - This addition supports improved 2D interaction handling within the OpenGL context.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GLFW/OpenGL sample demos to match recent vne::interaction API changes (Inspect3DController + orbital/trackball + updated Ortho2D behavior naming), and refreshes sample docs/UI text accordingly.
Changes:
- Replace
InspectControllerusage withInspect3DControllerin shared sample layers and the interaction demo. - Update behavior accessors/usages (e.g.,
orbitArcballBehavior()→orbitalCameraBehavior(),orthoPanZoomBehavior()→ortho2DBehavior()), and add trackball projection UI controls. - Refresh sample READMEs and inline comments to reflect “orbit / trackball” terminology.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/glfw_opengl/common/base_scene_layer.h | Switches interaction include/types to Inspect3DController; updates interaction layer comment text. |
| samples/glfw_opengl/common/base_scene_layer.cpp | Updates controller instantiation and accessors to Inspect3DController. |
| samples/glfw_opengl/03_test_interaction/demo_test_interaction.h | Updates inspect controller types and renames the inspect mode enum value to trackball. |
| samples/glfw_opengl/03_test_interaction/demo_test_interaction.cpp | Updates behavior includes/usages; adds trackball projection UI; updates controller switching logic for trackball. |
| samples/glfw_opengl/03_test_interaction/README.md | Updates documentation to describe trackball + projection options. |
| samples/glfw_opengl/02_test_scene/demo_test_scene.cpp | Updates interaction layer comment text to “orbit/trackball”. |
| samples/glfw_opengl/01_test_events/demo_test_events.cpp | Updates interaction layer comment text to “orbit/trackball”. |
| samples/glfw_opengl/00_hello_testbed/demo_hello_testbed.cpp | Updates interaction layer comment text to “orbit/trackball”. |
| samples/glfw_opengl/00_hello_testbed/README.md | Updates documentation text to reflect orbit/trackball inspect terminology. |
- Eliminated the scene scale application logic from the onUpdate method, streamlining the update process. - This change enhances code clarity by removing unnecessary conditional checks related to the mesh layer's scale.
- Added logic to check and synchronize orthographic projection bounds based on viewport size and UI settings, preventing unnecessary updates. - Introduced new member variables to track the last applied orthographic projection settings, enhancing performance during rendering. - Updated comments to clarify the purpose of the new synchronization mechanism.
…_test_interaction - Changed the order of zoom method options in the UI for better user experience. - Updated descriptions for each zoom method to provide clearer explanations of their functionality.
…raction demo - Renamed instances of the Ortho controller to Ortho2D for consistency across the codebase. - Updated method names and comments to reflect the new controller type, ensuring clarity in interaction handling. - Adjusted UI elements and documentation to accurately describe the Ortho2D controller's requirements and functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release notes: Use a Conventional Commits–style PR title (e.g.
feat: add X,fix: resolve Y,docs: update Z) so release-please can include this change in the changelog. If you squash-merge, use the PR title as the commit message.Checklist
cmake -B buildandcmake --build build, or platform script).ctest --test-dir buildor script-a test).clang-formatas configured for this repo); CI clang-format will check.Additional notes