feat(common): add the css_rebuild manifest opt-in#1664
Merged
Conversation
4 tasks
AppCssMeta is the capability metadata a plugin module exports next to its inline css (the isolation modes the build's payloads support). AppUIConfig gains legacy_css_compat: when set, a host may rebuild a legacy build's css from its stylesheet at load time. Both are additive and default-off. The host that consumes these types ships on this maintenance line; the plugin-builder change that emits cssMeta ships on the main line. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JpAEfftYG74jVAFhZ87EcD
cmorman89
force-pushed
the
fix-plugin-css-mode
branch
from
July 9, 2026 16:13
014afaf to
e460eb7
Compare
Scope the manifest contract to shipped behavior: the host decides css handling from the manifest alone, so the module-side capability marker is not consumed anywhere. Reword the legacy_css_compat doc for the operator editing a manifest rather than the host internals. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JpAEfftYG74jVAFhZ87EcD
Name the flag by what it does — the host rebuilds the app's css from its stylesheet at load time — instead of by a build-generation story. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JpAEfftYG74jVAFhZ87EcD
cmorman89
changed the title
gspradlin
approved these changes
Jul 9, 2026
Contributor
|
✅ Opened a backport to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one additive, default-off field to
@vertesia/common:AppUIConfig.css_rebuild(defaultfalse) — a manifest opt-in. When true, the host modifies the app's css at load time to attempt to fix broken or missing styles. Only takes effect in css isolation mode.Type-only; no runtime behavior lives in this package. The host that consumes it ships in the Vertesia web app off this same maintenance line. The build-tool fix that makes future builds correct at the source ships separately on the main line (#1699).
Verification
@vertesia/commonbuilds; lint clean. The field is optional and default-off — no existing consumer changes.Test Plan
@vertesia/common🤖 Generated with Claude Code
https://claude.ai/code/session_01JpAEfftYG74jVAFhZ87EcD