Conversation
This commit introduces the ability to track progress based on steps in addition to percentage. - Adds `totalSteps` and `currentStep` properties. - Adds `setTotalSteps(int $steps)` method to initialize step tracking. - Adds `advance(int $step = 1)` method to increment current step and automatically calculate progress percentage. - Adds `getTotalSteps()` and `getCurrentStep()` getters. - Updates `updateLocalProgressData` to include `current_step` and `total_steps` in the stored progress data. - Adds comprehensive tests for the new functionality. - Adds `TotalStepsNotSetException` for error handling.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Rejeitado: A funcionalidade proposta adiciona complexidade desnecessária. A API atual com incrementLocalProgress() + metadata já resolve este caso de uso de forma mais simples e flexível. |
Entendido. Agradeço o feedback. Vou reverter as alterações e manter a simplicidade da API atual. |
1 participant
This pull request adds support for step-based progress tracking. This allows users to set a total number of steps and increment the current step, which automatically updates the progress percentage. This is useful for tasks where the total number of items to process is known. It also exposes the current step and total steps in the progress data, which can be used by frontends to display "X of Y" progress.
PR created automatically by Jules for task 14218695671066004975 started by @insign