fix: Fix rclone binary detection in ProcessManager#18
Conversation
- Update `ProcessManager::guessBin` to pass `null` as default to `ExecutableFinder::find`. - Add `ProcessManager::$executableFinder` and `setExecutableFinder` for testing. - Add `tests/Unit/ProcessManagerTest.php` to verify behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Modified ProcessManager::guessBin to correctly handle the case when rclone binary is not found by passing null as default to ExecutableFinder. Added static method setExecutableFinder to allow dependency injection for testing. Added unit tests covering both found and not found scenarios.
PR created automatically by Jules for task 7675654203172392090 started by @insign