Fix: Correctly handle missing rclone binary in guessBin#16
Fix: Correctly handle missing rclone binary in guessBin#16
Conversation
- Introduce `ProcessManager::setExecutableFinder()` for better testability. - Fix logic in `guessBin()` to throw `RuntimeException` immediately when rclone is not found, instead of defaulting to `/usr/bin/rclone` (which may not exist). - Add unit tests for `ProcessManager` to verify binary detection behavior. - Update `ConfigurationTest` to mock `ExecutableFinder`, ensuring tests pass in environments without rclone.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
insign
deleted the
fix/process-manager-guess-bin-11192536405937360082
branch
1 participant
This PR fixes a bug in
ProcessManager::guessBin()where it would silently default to/usr/bin/rcloneif the binary was not found, leading to confusing runtime errors later. It now throws aRuntimeExceptionimmediately.It also introduces dependency injection for
ExecutableFinderviaProcessManager::setExecutableFinder(), making the binary detection logic testable. A new test suitetests/Unit/ProcessManagerTest.phpis added, andtests/Unit/ConfigurationTest.phpis updated to mock the binary finder.PR created automatically by Jules for task 11192536405937360082 started by @insign