Conversation
Added `hashsum` method to `Rclone` class to support generic checksum calculation with specified algorithm (e.g. md5, sha1). Added unit test `test_hashsum_command` in `tests/Unit/ExtraCommandsTest.php` covering md5 and sha1 algorithms.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Closing: will apply improvements locally (refactor md5sum/sha1sum to delegate to hashsum, fix code style). |
Understood. I will stop working on this task. |
- Add hashsum() method supporting any rclone hash algorithm - Refactor md5sum() and sha1sum() to delegate to hashsum(), removing duplicated parsing logic - Add test_hashsum_command covering md5 and sha1 algorithms - Update CODEBASE.md with new method - Closes #13 (applied locally with improvements)
1 participant
Implemented
hashsummethod inRclone.phpto allow calculating checksums with various algorithms supported by rclone. Added corresponding test case intests/Unit/ExtraCommandsTest.php.Verified withphpunit.PR created automatically by Jules for task 7667133079508747177 started by @insign