Conversation
- Added `global` field to `Args` struct in `src/cli/parser.rs` - Implemented `history` subcommand and `--global` flag parsing - Added `show_global_history` method to `ContextManager` in `src/context/manager.rs` - Updated `src/cli/mod.rs` to handle global history display This allows users to view conversation history across all directories using `ask history --global`. Local history can be viewed using `ask history` or `ask -c history`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd9d24e6e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Subcommands | ||
| "init" | "config" if query_parts.is_empty() => result.init = true, | ||
| "profiles" if query_parts.is_empty() => result.list_profiles = true, | ||
| "history" if query_parts.is_empty() => result.show_history = true, |
There was a problem hiding this comment.
history as subcommand only when no query follows
This branch marks history as a command whenever it is the first non-flag token, even if additional words follow, so inputs like ask history of linux (or ask -c history of linux) set show_history and bypass normal query execution. That introduces a keyword collision with regular prompts and silently drops user intent for queries that begin with “history.”
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| // Handle history commands (global or local) | ||
| if args.show_history { |
There was a problem hiding this comment.
--clear behavior when --history is also set
Handling show_history before context commands causes ask -c --clear --history to return early from the history path, so manager.clear_current() is never reached and the clear flag is silently ignored. This is a regression from the previous ordering where --clear took precedence, and it can leave stale context in place when users explicitly request clearing it.
Useful? React with 👍 / 👎.
1 participant
Implemented the
ask history --globalcommand as requested in the roadmap. This feature allows users to list all stored conversation contexts, sorted by last used time.Key changes:
src/cli/parser.rs: Added support forhistorysubcommand and--globalflag.src/context/manager.rs: Added logic to list and display all contexts from storage.src/cli/mod.rs: Integrated the new command into the CLI execution flow.Verification:
ask history --global.ask -c historyfunctionality is preserved.make precommit.PR created automatically by Jules for task 8655789474397182841 started by @insign