fix: prevent media type mismatch in closed media section reuse#363
Conversation
|
Thanks @duyjack , we'll review and check in the following days. |
|
This will take few more days as we'd like to make a further research and are currently short on time. |
Co-authored-by: Astagor <astagor@gmail.com>
|
My FF users are getting angry. Any info about the fix date? Also please see this #364 (comment) there might other things to fix for FF. |
We are on vacation. Will check this on our arrival to normal life. Please open a separate ticket for that different issue. |
|
Verified that it works and fixes latest Firefox. Merging. Thanks. |
|
NOTE: I will fix CI errors once merged. @duyjack, for future PRs please run |
|
Released in mediasoup-client 3.18.8. |
Description
Fix an issue in
RemoteSdp.receive()where closed media sections could be recycledregardless of their media type, potentially causing type mismatch errors.
Changes
m.closed == trueANDm.getObject().type === kindMotivation
Previously, the code could recycle a closed
m=audiosection for newm=videomedia,which would cause type inconsistencies. The updated logic ensures type compatibility
when attempting to reuse closed media sections.
Testing
This fix prevents potential mismatches between the media section type and the requested kind,
improving the robustness of SDP media section management.