Skip to content

[ci] chore: fix vllm_ascend ci#6839

Open
wucong25 wants to merge 4 commits into
verl-project:mainfrom
wucong25:wc/test_ci
Open

[ci] chore: fix vllm_ascend ci#6839
wucong25 wants to merge 4 commits into
verl-project:mainfrom
wucong25:wc/test_ci

Conversation

@wucong25

@wucong25 wucong25 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

fix vllm_ascend ci

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@wucong25 wucong25 marked this pull request as draft June 24, 2026 09:59

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the hardcoded torch.npu.empty_cache() call with a device-agnostic get_torch_device().empty_cache() call in hccl_checkpoint_engine.py to improve compatibility across different hardware backends. There are no review comments, so no additional feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@wucong25 wucong25 closed this Jun 25, 2026
@wucong25 wucong25 reopened this Jun 29, 2026
@wucong25 wucong25 marked this pull request as ready for review June 29, 2026 09:46
@wucong25 wucong25 changed the title [ci] chore: test ci [ci] chore: fix vllm_ascend ci Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant