[train] Gateway anthropic adapter#70
Conversation
… stop param, drop tool_call id from prefix comparison
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces provider adapters for Anthropic and OpenAI to translate wire protocol requests into a canonical internal format (InternalGenerationRequest), decoupling wire translation from the session and codec logic. It also adds a standalone gateway debug launcher (debug_launcher.py) with extensive documentation and comprehensive unit tests. Feedback on the debug launcher suggests simplifying the redundant type checking and decoding logic for TimeoutExpired exceptions since subprocess.run is invoked with text=True.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| stdout = exc.stdout if exc.stdout is not None else exc.output | ||
| stderr = exc.stderr | ||
| if isinstance(stdout, bytes): | ||
| stdout = stdout.decode(errors="replace") | ||
| elif stdout is None: | ||
| stdout = "" | ||
| else: | ||
| stdout = str(stdout) | ||
| if isinstance(stderr, bytes): | ||
| stderr = stderr.decode(errors="replace") | ||
| elif stderr is None: | ||
| stderr = "" | ||
| else: | ||
| stderr = str(stderr) |
There was a problem hiding this comment.
The subprocess.run call uses text=True, so exc.stdout and exc.stderr from a TimeoutExpired exception will be strings or None. The complex type checking and decoding logic for these attributes can be simplified.
Additionally, exc.output is an alias for exc.stdout, making the conditional assignment on line 450 redundant.
| stdout = exc.stdout if exc.stdout is not None else exc.output | |
| stderr = exc.stderr | |
| if isinstance(stdout, bytes): | |
| stdout = stdout.decode(errors="replace") | |
| elif stdout is None: | |
| stdout = "" | |
| else: | |
| stdout = str(stdout) | |
| if isinstance(stderr, bytes): | |
| stderr = stderr.decode(errors="replace") | |
| elif stderr is None: | |
| stderr = "" | |
| else: | |
| stderr = str(stderr) | |
| stdout = exc.stdout or "" | |
| stderr = exc.stderr or "" |
… nested helpers - 收紧 ANTHROPIC_ERROR_TYPE_BY_STATUS 和 _OPENAI_ERROR_TYPE_BY_STATUS 到实际产出的状态码（400/409/500 和 400/409），去掉鉴权/限流/404 等 gateway 不会产生的映射 - 统一所有 text block join 为 "\n" 分隔（system / tool_result / user / assistant），对齐 Slime/PolAR/AReaL，避免 Claude Code prompt caching 拆分的多 block 粘连 - 提升嵌套 helper 到 module level：_fold_reminder_into_user、_infer_json_type、_infer_any_of_type，消除不必要的闭包嵌套 - 重构 mid-list system 折叠逻辑为独立函数 _fold_mid_list_system_into_user，与 _messages_to_internal 解耦 - 删除未使用 helper _text_part / _content_parts_or_text，逻辑 inline - 调整 flush 函数为 early-return 风格，与 flush_user 对称 - 删除低价值测试文件 test_public_exports.py Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Route gateway tool-call decode through SGLang/vLLM parsers instead of VERL Pydantic schemas. Keep Anthropic tool schemas as copied OpenAI function parameters.
1 participant
Summary
examples/gateway/debug_launcher.pyplus docs and tests for local gateway debugging and trajectory collection.Testing
pytest -q tests/uni_agent/gateway/test_debug_launcher.py tests/uni_agent/gateway/adapters/test_openai_adapter.py tests/uni_agent/gateway/adapters/test_anthropic_adapter.py tests/uni_agent/gateway/test_gateway_actor_on_cpu.py