Skip to content

Typos and Noop Default in Callback - #6

Open
ssoelvsten wants to merge 2 commits into
verilog-to-routing:masterfrom
ssoelvsten:noop_default
Open

Typos and Noop Default in Callback#6
ssoelvsten wants to merge 2 commits into
verilog-to-routing:masterfrom
ssoelvsten:noop_default

Conversation

@ssoelvsten

Copy link
Copy Markdown
Contributor
  • Fixes spelling error of unknown (the second n is missing); this is a breaking change.
  • Fixes some spelling errors in comments.
  • Makes the default implementation of the Callback class lots of noops. This way, one only has to overload/implement the few relevant functions.

This makes the derived code much cleaner, since boiler plate code is omitted
@vaughnbetz

Copy link
Copy Markdown
Contributor

Thanks, and sorry I didn't notice this until now. When you say this is a breaking change, does anything in VTR (users of the parser) break?

@vaughnbetz

Copy link
Copy Markdown
Contributor

@soheilshahrouz : while you're checking out the make format on libblifparse, could you also test this change works fine with VTR? If so I'll merge it.

@ssoelvsten

ssoelvsten commented Nov 1, 2024

Copy link
Copy Markdown
Contributor Author

No worries about the delay; thanks for this parser - it has been great help for my research. 🙂 If a user of the parser makes use of the LogicValue enum (which I'd imagine they would), then compilation breaks. If bumping the major version number is not desirable, then one can exclusively merge 9771095 in instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants