Typos and Noop Default in Callback - #6
Open
ssoelvsten wants to merge 2 commits into
Open
Conversation
ssoelvsten
commented
May 3, 2024
Contributor
- Fixes spelling error of unknown (the second n is missing); this is a breaking change.
- Fixes some spelling errors in comments.
- Makes the default implementation of the Callback class lots of noops. This way, one only has to overload/implement the few relevant functions.
This makes the derived code much cleaner, since boiler plate code is omitted
Contributor
|
Thanks, and sorry I didn't notice this until now. When you say this is a breaking change, does anything in VTR (users of the parser) break? |
Contributor
|
@soheilshahrouz : while you're checking out the make format on libblifparse, could you also test this change works fine with VTR? If so I'll merge it. |
Contributor
Author
|
No worries about the delay; thanks for this parser - it has been great help for my research. 🙂 If a user of the parser makes use of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.