Fix compilation on aarch64#9
Merged
Merged
Conversation
-> replace __float128 by _Float128 -> call get_tid with syscall with @yohanchatelain
There was a problem hiding this comment.
Pull request overview
This PR aims to restore/build compatibility on aarch64 by adjusting (1) the project’s 128-bit floating-point alias and (2) the way thread IDs are obtained for RNG seeding.
Changes:
- Switch RNG thread-id retrieval from
gettid()tosyscall(...)inxoshiro_vector.cpp. - Update
Float128typedef logic inutils.hto prefer_Float128off x86_64.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/xoshiro_vector.cpp |
Uses syscall(__NR_gettid) instead of gettid() for RNG seeding; adds <sys/syscall.h>. |
src/utils.h |
Changes Float128 selection logic to use __float128 on x86_64 and _Float128 elsewhere. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
Member
Author
|
yohanchatelain
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-> replace __float128 by _Float128
-> call get_tid with syscall
with @yohanchatelain