Skip to content

predict_predicate_mention method forgets to change the prop_mentions_by_key #10

Description

@hitzkrieg

The predict_predicate_mention method in the file eval_predicate_mention.py takes a gold graph and returns the same graph with predicted predicate mentions instead of gold ones.
However it forgets to change the prop_mentions_by_key dictionary for the newly created graph (prop_mentions_by_key remains the old value). Also it would be helpful if the method also annotates the argument_mentions found from prop_ex.

Thanks :)

https://github.com/vered1986/OKR/blob/master/src/baseline_system/eval_predicate_mention.py#L67

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions