Skip to content

fix: refactor createChunkTransformStream type definitions #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odaysec wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

fix: refactor createChunkTransformStream type definitions #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/blob/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,15 +455,16 @@ export function computeBodyLength(body: PutBody): number {
export const createChunkTransformStream = (
chunkSize: number,
onProgress?: (bytes: number) => void,
): TransformStream<ArrayBuffer | Uint8Array> => {
): TransformStream<ArrayBuffer | Uint8Array, Uint8Array> => {
let buffer = new Uint8Array(0);

return new TransformStream<ArrayBuffer, Uint8Array>({
return new TransformStream<ArrayBuffer | Uint8Array, Uint8Array>({
transform(chunk, controller) {
// Combine the new chunk with any leftover data
const newBuffer = new Uint8Array(buffer.length + chunk.byteLength);
const chunkData = chunk instanceof Uint8Array ? chunk : new Uint8Array(chunk);
const newBuffer = new Uint8Array(buffer.length + chunkData.byteLength);
newBuffer.set(buffer);
newBuffer.set(new Uint8Array(chunk), buffer.length);
newBuffer.set(chunkData, buffer.length);
buffer = newBuffer;

// Output complete chunks
Expand Down