Skip to content

test: add regression coverage for @paypal/paypal-js sdk-v6 subpath (issue #599) #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
styfle wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test: add regression coverage for @paypal/paypal-js sdk-v6 subpath (issue #599) #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0abf2b9
test: add regression coverage for @paypal/paypal-js sdk-v6 subpath
cursoragent Jul 6, 2026
55366aa
test: use workspace @paypal/paypal-js instead of fixture node_modules
cursoragent Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"@google-cloud/bigquery": "^8.3.1",
"@google-cloud/firestore": "^7.6.0",
"@opentelemetry/api": "^1.7.0",
"@paypal/paypal-js": "10.0.1",
"@sentry/node": "^9.2.0",
"@tpluscode/sparql-builder": "^0.3.12",
"@types/bindings": "^1.3.0",
Expand Down
15 changes: 15 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions test/integration/paypal-js-sdk-v6.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Regression test for https://github.com/vercel/nft/issues/599
// @paypal/paypal-js@10.0.1 exposes ./sdk-v6 with only "types" + "import"
// conditions. Tracing must include dist/v6/esm/paypal-js.js so the named
// export loadCoreSdkScript resolves at runtime after packaging.
import { loadCoreSdkScript } from '@paypal/paypal-js/sdk-v6';

if (typeof loadCoreSdkScript !== 'function') {
throw new Error(
`Expected loadCoreSdkScript to be a function, got ${typeof loadCoreSdkScript}`,
);
}
3 changes: 2 additions & 1 deletion test/unit.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ for (const { testName, isRoot } of unitTests) {
testName === 'module-create-require-named-require' ||
testName === 'module-create-require-named-import' ||
testName === 'module-create-require-ignore-other' ||
testName === 'module-create-require-destructure'
testName === 'module-create-require-destructure' ||
testName === 'paypal-js-sdk-v6'
) {
inputFileNames = ['input.mjs'];
}
Expand Down
3 changes: 3 additions & 0 deletions test/unit/paypal-js-sdk-v6/input.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { loadCoreSdkScript } from '@paypal/paypal-js/sdk-v6';

console.log(typeof loadCoreSdkScript);
5 changes: 5 additions & 0 deletions test/unit/paypal-js-sdk-v6/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[
"node_modules/@paypal/paypal-js/dist/v6/esm/paypal-js.js",
"node_modules/@paypal/paypal-js/package.json",
"test/unit/paypal-js-sdk-v6/input.mjs"
]
Loading