Skip to content

perf: use indexed capture groups instead of named ones in parse() #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ordinary9843 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

perf: use indexed capture groups instead of named ones in parse() #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,20 +75,16 @@ export function parse(str: string): number {
);
}
const match =
/^(?<value>-?\d*\.?\d+) *(?<unit>milliseconds?|msecs?|ms|seconds?|secs?|s|minutes?|mins?|m|hours?|hrs?|h|days?|d|weeks?|w|months?|mo|years?|yrs?|y)?$/i.exec(
/^(-?\d*\.?\d+) *(milliseconds?|msecs?|ms|seconds?|secs?|s|minutes?|mins?|m|hours?|hrs?|h|days?|d|weeks?|w|months?|mo|years?|yrs?|y)?$/i.exec(
str,
);

if (!match?.groups) {
if (!match) {
return NaN;
}

// Named capture groups need to be manually typed today.
// https://github.com/microsoft/TypeScript/issues/32098
const { value, unit = 'ms' } = match.groups as {
value: string;
unit: string | undefined;
};
const value = match[1];
const unit = match[2] ?? 'ms';

const n = parseFloat(value);

Expand Down