Skip to content

fix(slack): resolve reaction user display names#523

Open
akkadaska wants to merge 1 commit into
vercel:mainfrom
akkadaska:main
Open

fix(slack): resolve reaction user display names#523
akkadaska wants to merge 1 commit into
vercel:mainfrom
akkadaska:main

Conversation

@akkadaska
Copy link
Copy Markdown

@akkadaska akkadaska commented May 18, 2026

Summary

Fixes Slack reaction events so event.user.userName and event.user.fullName are resolved from Slack user profile data instead of always being the raw Slack user ID.

This reuses the Slack adapter's existing cached lookupUser() path and falls back to the user ID when lookup fails.

Fixes #521

Test plan

  • Manually verified in Slack that chat.onReaction() receives the reacting user's display name in event.user.userName instead of the raw Slack user ID.
  • Manually verified in Slack that chat.onReaction() receives the reacting user's real name in event.user.fullName instead of the raw Slack user ID.
  • Manually verified that event.user.userId still contains the raw Slack user ID.
  • pnpm --filter @chat-adapter/slack exec vitest run src/index.test.ts -t "resolves reaction user display name|resolves parent thread_ts"
  • pnpm --filter @chat-adapter/slack typecheck
  • pnpm --filter @chat-adapter/slack build
  • pnpm validate

Checklist

  • All commits are signed and verified
  • pnpm validate passes
  • Changeset added (or N/A — see CONTRIBUTING.md)
  • Documentation updated (or N/A)

@akkadaska akkadaska requested a review from a team as a code owner May 18, 2026 14:34
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 18, 2026

@akkadaska is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slack: reaction events expose user IDs instead of display names

1 participant