Repository navigation
Conversation
The addTest tip omitted the required arg1 attribute, so following it failed validation. The language reference also said an out-of-range index exits without output, but the runtime prints trap: index out of bounds to stderr. Fixes vercel-labs#442
|
@mliem2k is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two small mismatches on main:
zero testtip showsaddTestwithout the requiredarg1attribute, so following the tip fails validation.skill-data/language.mdsays an out-of-range index exits with no output, but the runtime printstrap: index out of boundsto stderr.Fixes #442.
Change
Update the tip to the two-argument form used by the patch examples, correct the language reference wording, and regenerate
embedded_skills.incfromskill-data.Verification
make -C native/zero-cnode --experimental-strip-types --disable-warning=ExperimentalWarning scripts/embed-skill-data.mts