Carry request path through 404 page links for smoother OAuth redirects#166
Open
oosawy wants to merge 3 commits intovercel-labs:mainfrom
Open
Carry request path through 404 page links for smoother OAuth redirects#166oosawy wants to merge 3 commits intovercel-labs:mainfrom
oosawy wants to merge 3 commits intovercel-labs:mainfrom
Conversation
|
@oosawy-ab is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
77a28f1 to
6b62cc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in the google-oauth example, using plain
localhostas the OAuth redirect URI means you lose the portless benefits for the callback flow. But the callback does land on portless's 404 page, which already lists active apps — you can manually click through to the right one. The only thing missing is that the path and query string get dropped along the way.Changes
req.urlto the active-app links on the 404 page so the full path and query string carry over/) produce clean links with no trailing slashTest plan
pnpm test— 3 new test cases (path preserved, path + query preserved, root path omitted)If desired, we could also surface an extra hint on the 404 page when the request has a non-root path, but kept it minimal for now.