Replace std::regex and fix reading negative values#14
Open
JanMarvin wants to merge 8 commits intovelofrog:masterfrom
Open
Replace std::regex and fix reading negative values#14JanMarvin wants to merge 8 commits intovelofrog:masterfrom
std::regex and fix reading negative values#14JanMarvin wants to merge 8 commits intovelofrog:masterfrom
Conversation
JanMarvin
commented
Feb 22, 2025
| # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help | ||
| on: | ||
| push: | ||
| branches: [main, master, no_regex] |
Author
There was a problem hiding this comment.
no_regex is only required to trigger a build from my github fork
JanMarvin
changed the title
std::regex and fix reading negative values
The note is a bit annoying, but getting the correct cxx standard seems even more annoying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @velofrog ,
Untested if this actually fixes the ASAN issue, but no ASAN docker around at the moment (was unable to reproduce the issue with
rockeror wch'sr-debugwhich still has gcc 12 iirc). Chances are that the ASAN issue was just a false positive, but I simply don't likestd::regexit is slow and sometimes hangs forever.Therefore this PR changes the following:
std::regexwith simpler codetestthatand some basic tests, just because I needed something to test the changesI'm not using the package, but have had a look while writing my own xlsb parser for
openxlsx2and came across CRANs archival note, while checking the reference in my "book". It would be a shame if the package will be lost.