fix: allow repeatable directives on Graphql document#418
Open
fredzqm wants to merge 1 commit intovektah:masterfrom
Open
fix: allow repeatable directives on Graphql document#418fredzqm wants to merge 1 commit intovektah:masterfrom
fredzqm wants to merge 1 commit intovektah:masterfrom
Conversation
Fixes a panic when validating directives that are not defined in the schema. Previously, the UniqueDirectivesPerLocation rule would panic if a directive did not have a definition, as it tried to access . This change adds a nil check for before accessing . A directive is considered non-repeatable if its definition is not found or if its definition explicitly states it is not repeatable. Added test cases for: - A custom repeatable directive used multiple times (expected no error). - A custom non-repeatable directive used multiple times (expected error).
Contributor
Author
|
@StevenACoffman [not in a rush] I think I may have caught a bug in the current parser. Let me know what you think~ Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Previously, the UniqueDirectivesPerLocation rule was checking
dir.Name != "repeatable", which was incorrect.It only allowed
directive @repeatableto be repeated.After
It should look for
dir.Definition.IsRepeatable, which allowsdirective @check repeatable on FIELDto be specified many times in the same place.Added test cases for:
Describe your PR and link to any relevant issues.
I have: