Fix repeated cumflation hediff creation on missing genitals - #56
Open
NovSugarMan wants to merge 1 commit into
Open
Fix repeated cumflation hediff creation on missing genitals#56NovSugarMan wants to merge 1 commit into
NovSugarMan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
ThinkNode_ConditionalCumflationSeverity.Satisfied only needs to determine whether an existing cumflation hediff exceeds AutoDeflateMinSeverity.
Calling GetOrCreateCumflationHediff creates a zero-severity hediff when none exists. If the pawn's genitals body part is missing, RimWorld rejects that hediff and the recurring think-tree evaluation retries the operation, repeatedly logging:
Tried to add health diff to missing part BodyPartRecord(Genitals parts.Count=0)
Using GetFirstHediffOfDef preserves the normal behavior: actual cumflation still creates the hediff through CumflatePawn, while the AI condition only reads it.
Testing
This PR intentionally targets RimWorld 1.6 only because that is the version tested locally.