config: make yaml parsing self contained lib#384
Draft
MariusBgm wants to merge 7 commits into
Draft
Conversation
Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
move to SilKitYaml Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
VDanielEdwards
left a comment
Member
There was a problem hiding this comment.
Looks good to me overall. When using it from the sil-kit repository, the dependency on the rapidyaml target can be added as a subdirectory as well:
cmake_minimum_required(VERSION 3.24)
project(SilKitYamlTest)
add_subdirectory(
"${CMAKE_CURRENT_SOURCE_DIR}/../sil-kit-b-yaml/ThirdParty/rapidyaml"
"${CMAKE_CURRENT_BINARY_DIR}/_deps/rapidyaml"
EXCLUDE_FROM_ALL
)
add_library(rapidyaml ALIAS rapidyaml-static)
add_subdirectory(
"${CMAKE_CURRENT_SOURCE_DIR}/../sil-kit-b-yaml/SilKitYaml"
"${CMAKE_CURRENT_BINARY_DIR}/_deps/SilKitYaml"
EXCLUDE_FROM_ALL
)
add_executable("${PROJECT_NAME}" main.cpp)
target_link_libraries("${PROJECT_NAME}" PRIVATE SilKitYaml)
Co-authored-by: Daniel Edwards <daniel.edwards@vector.com> Signed-off-by: Marius Börschig <marius.boerschig@vector.com>
Co-authored-by: Daniel Edwards <daniel.edwards@vector.com> Signed-off-by: Marius Börschig <marius.boerschig@vector.com>
…yaml dont use rapidyaml in capability parser Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
…silkit_yaml Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
Collaborator
Author
that's a very good point: consuming the SilKitYaml fails if you do not provide the rapidyaml. |
…parate silkit_yaml Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out SilKitYaml, as selfcontained interface to rapidyaml (including rapidyaml itself).
Allows reusing the YamlReader/Writer in other tools.
this is an internal lib, not part of the public SilKit API surface