Repository navigation
Improve renderer failure handling - #645
Open
charlesstaats wants to merge 2 commits into
Open
charlesstaats wants to merge 2 commits into
charlesstaats wants to merge 2 commits into
Conversation
When rendering in a forked child, the parent waited for it but ignored its status, so a crash or error exit in the renderer (e.g. a GC abort or a missing Vulkan driver) left asy exiting 0 without writing an image. Now a child killed by a signal or exiting non-zero is reported as an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tests/test_render3d.py renders a small scene to PNG and fails if asy exits non-zero or writes no PNG. It exits 77 (skipped) when asy was built without Vulkan or the Vulkan loader reports no devices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Report a failed 3D render child instead of exiting 0, and add a 3D rendering test
When asy renders a 3D scene in a forked child process, the parent waited for the child but ignored its exit status. If the renderer crashed or exited with an error, asy still exited 0 and simply wrote no image. Two examples: a Boehm GC abort ("Collecting from unknown thread") when
gccppis linked and lavapipe is used, or an uncaughtvk::IncompatibleDriverErrorwhen no Vulkan driver is present.picture.cc: if the render child is killed by a signal or exits non-zero, report an error. asy then exits 1 with a message such asruntime: 3D renderer terminated by signal 6 (Aborted). Interactive viewing, which doesn't wait for the child, is unchanged.tests/test_render3d.py: renders a small 3D scene to PNG. The test fails if asy exits non-zero or doesn't write a valid PNG. It runs under both ctest (bundled.asy.render3d) andmake check.On a machine with a Vulkan device, the new test fails with the CMake build on master until the fix that stops linking
gccppoutside Windows is merged.Testing (Debian trixie, lavapipe):
linux/release, master, which linksgccpp):render3dfails with the error above. WithGC_DONT_GC=1, ctest passes 8/8.make checkpasses, includingrender3d.VK_ICD_FILENAMESpointed at a nonexistent file): the test is skipped under both ctest andmake.misc-sanity-checks.yml.🤖 Generated with Claude Code