Skip to content

Add options for custom selectors.#36

Open
jasonfarrell wants to merge 1 commit into
vdw:masterfrom
UseAllFive:custom-selectors
Open

Add options for custom selectors.#36
jasonfarrell wants to merge 1 commit into
vdw:masterfrom
UseAllFive:custom-selectors

Conversation

@jasonfarrell

Copy link
Copy Markdown

This allows users to pass a selector for the tab content and any selector for tab links.
It keeps the defaults.

@vdw vdw added the enhancement label Jan 6, 2016
@jasonfarrell

Copy link
Copy Markdown
Author

I'm fixing the new conflicts now…

This allows users to pass a selector for the tab content and any selector for tab links.
It keeps the defaults.
@jasonfarrell

Copy link
Copy Markdown
Author

@vdw ready to be merged — if you agree with my changes!

@brandensilva

brandensilva commented Sep 3, 2016

Copy link
Copy Markdown

👍

Could really use targets classes so the tab list can be outside the scope of the tab contents.

somewhere else on the page

<div class="tab-list">
  <a href="overview">Overview</a>
  <a href="directions">Directions</a>
</div>

main content

<div class="tabs">
  <div class="tab" id="overview">Tab 1 Content</div>
  <div class="tab" id="directions">Tab 2 Content</div>
</div>

@jasonfarrell @vdw Any luck fixing those merge conflicts?

@flowdee

flowdee commented Mar 30, 2017

Copy link
Copy Markdown

This would be amazing! @vdw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants