Capability to ignore parsing emoji aliases inside url links#110
Open
fredericojssilva wants to merge 4 commits into
Open
Capability to ignore parsing emoji aliases inside url links#110fredericojssilva wants to merge 4 commits into
fredericojssilva wants to merge 4 commits into
Conversation
Owner
|
This looks good! The URL regex probably won't catch all the cases though. Maybe we should use a more complete one? What do you think? |
Author
|
@vdurmont agreed. Pushed a more complete one. |
Author
|
Hey @vdurmont. Have you had a chance to look at it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Taking the following string as example:
hello :smiley:. The link is https://link_with_emoji_alias_:smiley:_that_we_do_not_want_to_replaceCurrently parsing the above string to unicode will become:
hello 😃. The link is https://link_with_emoji_alias_😃_that_we_do_not_want_to_replaceAdded a new method
parseToUnicode(String input, boolean shouldIgnoreUrls)that will allow us to ignore the parsing inside urls.The result will be a not broken link:
hello 😃. The link is https://link_with_emoji_alias_:smiley:_that_we_do_not_want_to_replace