Repository navigation
open-pr: never @mention anyone in a PR body - #55
Merged
Merged
Conversation
The team hears about a PR through other channels and nobody acts on the GitHub ping, so a mention only adds noise. The template now names people in plain words, the checker fails on any @mention, and the --author option, which existed only to catch a self-mention, is gone.
The skill still asked the user whether someone needs a heads-up, and the template explained the @ rule at length. Both kept mentions on the agent's mind, so it kept telling the user there were none. The checker still fails on an @mention, so the rule needs no explanation. Claude-Session: https://claude.ai/code/session_011Xdd9yzsbk9spr5rq9wHb8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open-pr now forbids
@mentionsin a PR body and stops talking about them. The team hears about a PR through other channels, so nobody acts on the GitHub ping and a mention only adds noise. The old mention prompts also made the agent keep telling the user there were none. This reverses the rule from #54.What changes
@, in one line.@mention, instead of warning. It prints nothing when there is none.--authoroption is gone. It existed only to catch a self-mention, which the new rule already fails.Tested
mise run verifyandplugins/open-pr/tests/test-open-pr.shpass.