This repository was archived by the owner on Jul 17, 2026. It is now read-only.
feat: bump naar league/glide v3 voor OC 4.1+ compatibiliteit (v5.0.0) - #5
Merged
Conversation
- composer.json: - php: ^8.0.2 -> ^8.2 (Glide v3 requirement) - league/glide: ^2.0 -> ^3.0 - league/glide-symfony: ^2.0 -> ^2.1 (eerste stable die Glide v3 toestaat) - october/rain: ^3.0 || ^4.0 -> ^3.0 || ^4.0 || ^4.1 || ^4.2 - updates/version.yaml + CHANGELOG.md: v5.0.0 entry - README.md: requirements bijgewerkt (PHP 8.2+, OC 3.x t/m 4.2.x), Glide-doc-link naar 3.0 - .github/workflows/php.yml: PHP-matrix 8.0-8.3 -> 8.2-8.5, deprecated composer flag --no-suggest verwijderd Geen PHP-code wijzigingen: Glide v3 publieke API is identiek aan v2 voor de keys die deze plugin gebruikt (geverifieerd in classes/GlideManager, classes/GlideHelper, controllers/Image).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
vdlp/oc-glide-pluginto 5.0.0 to make it composer-resolvable against OctoberCMS 4.1+. Without this bump, every project that depends on this plugin (directly or transitively viavdlp/sections) hits a hard composer resolve-fail when bumping to OC 4.1+, because OC 4.1+ requiresintervention/image ^3.10whileleague/glide ^2.0clamps tointervention/image ^2.x.Changes
Dependency bumps (
composer.json)php:^8.0.2→^8.2(Glide v3 requirement)league/glide:^2.0→^3.0league/glide-symfony:^2.0→^2.1(first stable release that allows Glide v3)october/rain: range extended with^4.1and^4.2Release metadata
updates/version.yaml: newv5.0.0entryCHANGELOG.md: new## [5.0.0]blockDocumentation & CI
README.md: requirements updated to PHP 8.2+ and OC 3.x through 4.2.x; Glide doc-link bumped from/2.0/to/3.0/..github/workflows/php.yml: PHP matrix moved from 8.0–8.3 to 8.2–8.5; removed deprecated--no-suggestcomposer flag.No code changes
Glide v3's public API is identical to v2 for the keys this plugin uses:
ServerFactory::create,SymfonyResponseFactory,SignatureFactory,UrlBuilderFactory,Server::makeImage,Server::setResponseFactory,Server::getImageResponse. Verified by readingclasses/GlideManager.php,classes/GlideHelper.php, andcontrollers/Image.php.Test plan
Verified locally against a real OctoberCMS 4.2.22 project using a composer path-repository pointing to this branch:
composer update --with-all-dependenciesresolves toleague/glide 3.2.0,league/glide-symfony 2.1.0,intervention/image 3.11.8php artisan october:migrateruns without fatals (Vdlp.Glide registered as v5.0.0)GlideManager::server()returnsLeague\Glide\ServerServer::makeImage('media/test.jpg', ['w' => 200, 'h' => 200, 'fit' => 'crop'])produces a valid 200×200image/jpegresponse