docs: weekly review 2026-05-14#7
Open
vasylenko wants to merge 1 commit into
Open
Conversation
SMAppService is used by MenuBarView (MenuBarView.swift imports ServiceManagement and calls SMAppService.mainApp.register/unregister/status), not by SleepManager. The previous diagram incorrectly placed it in the SleepManager subtree alongside powerd.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly documentation review — 2026-05-14
What was reviewed
All user-facing and maintainer-facing docs:
README.md— features, requirements, build/verify instructions, tech stackCLAUDE.md— tech stack, project structure, code style, testing, localization, CLI commands, distributionARCHITECTURE.md— system context diagram, design rationale, constraints, UserDefaults keys, error handlingPRD.md— product requirements, scope checklistsEach doc was cross-checked against the actual Swift source files (
VigilApp.swift,SleepManager.swift,MenuBarView.swift,Localizable.xcstrings,PrivacyInfo.xcprivacy,VigilTests.swift).Fixes
ARCHITECTURE.md— system context diagram:SMAppServiceplaced in wrong subtreeThe diagram showed
SMAppService(login item registration) as a dependency ofSleepManager, alongsidepowerd. In the actual code,SleepManager.swiftdoes not importServiceManagementand makes no reference toSMAppService. It isMenuBarView.swiftthat importsServiceManagementand callsSMAppService.mainApp.register(),.unregister(), and.status.The diagram now reflects the actual ownership:
SMAppServicebranches offMenuBarViewdirectly, while theSleepManagersubtree retains onlyIOKit → powerdandUserDefaults.Generated by Claude Code