Add localization for 5 languages#2
Merged
Merged
Conversation
- Change SleepMode.label and .description return types from String to LocalizedStringResource for auto-extraction into String Catalogs - Create Localizable.xcstrings with 11 translated strings for de, es, hi, and zh-Hans - Clean up knownRegions to match actual target languages - assertionReason strings intentionally left in English (system-facing) Created with Claude Code under the supervision of Serhii Vasylenko
Document String Catalog workflow, LocalizedStringResource convention, and how to add new translatable strings. Created with Claude Code under the supervision of Serhii Vasylenko
11 strings translated to Ukrainian (uk). Added uk to knownRegions. Created with Claude Code under the supervision of Serhii Vasylenko
Created with Claude Code under the supervision of Serhii Vasylenko
Build, test, build-and-run, locale testing, and assertion verification — all in copy-pasteable form. Created with Claude Code under the supervision of Serhii Vasylenko
awk pattern was too greedy, matched wrong build setting. Use grep + sed for exact BUILT_PRODUCTS_DIR match. Created with Claude Code under the supervision of Serhii Vasylenko
Avoids shadowing the CustomStringConvertible.description convention, especially now that the return type is LocalizedStringResource not String. Created with Claude Code under the supervision of Serhii Vasylenko
vasylenko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localizable.xcstrings)SleepMode.labeland.descriptionreturn types fromStringtoLocalizedStringResourcefor auto-extraction — new UI strings are picked up on build without manual registrationSleepMode.descriptiontomodeDescriptionto avoid shadowingCustomStringConvertibleconventionTest plan
xcodebuild build)xcodebuild test)python3 -m json.tool)open Vigil.app --args -AppleLanguages '(uk)'Created with Claude Code under the supervision of Serhii Vasylenko