change the logic behind fitToBbox#22
Open
SameC137 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old fitToBbox calculated fit distance using only the largest bbox half-extent from the world origin (center = (0,0,0)), which produced incorrect framing for off-center scenes and ignored the camera's current orientation.
The new implementation computes the geometric center of the bbox, extracts the camera's world-space right/up/forward axes and projects all 8 bbox corners onto the camera's view axes to compute the minimum required distance to fit both height and width and places the camera along its current forward direction (negated) from the center. I have kept the aspect the same though it is possible to fit on both axis with a recalculation of the aspect though it created weird renders and created a wonky effect.