Conversation
Deliver promoted messages into the active turn and wake delegate waits so corrective input does not wait for background work to finish. Hold turn settlement until transcript writes reach the host, preserving overflow across restart. Keep graceful stop latched through recovery and retry boundaries without aborting work already in progress. fixes vastsa#597
Keep persistence construction and transcript settlement together so the main entry remains within its architecture budget. Preserve lazy host and shutdown reads and the single-instance initialization boundary.
Owner
|
审查结论:暂不合入。方向解决了 Send now 顺序问题,但这是 steering + 持久化 outbox 的设计级改动;当前持续 Host 故障时超过 1024 条会无限追加并反复序列化恢复文件,存在磁盘/内存无界增长并阻塞会话的风险。另当前分支基线过旧且与 main 冲突。请先补配额/背压策略、基于最新 main 解决冲突并重跑验证。 |
Owner
|
感谢你对 Send now、steering 和持久化顺序问题的深入辅助,方向确实解决了真实痛点。当前暂不合入,建议重新提交前处理:
修好后请重新提 PR,我会继续跟进。 |
Owner
|
感谢贡献。先关闭当前 PR,待资源上限、设计拆分和最新 main 冲突处理完成后请重新提交。 |
Contributor
Author
好,目前还有什么你们没有人力去解决的么( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与行为
运行中点击“立即发送”会先请求正常停止,纠正指令因此可能等到子代理结束才被处理;落盘失败或积压时,上一轮回复也可能晚于下一条用户消息写入。
TaskWait收到新指令后提前返回,子代理继续执行。拒绝追加的消息保留在队列,结束后正常派发。验证
候选提交:
fa1442797d0e0fc23a4dbb8015164e7487568875基线:
7c0710fc38437725bd432d86ab4be05159ebd522(准备候选时最新 upstream/main)。pnpm build:js、桌面 typecheck、pnpm lint通过;持久化初始化移出主入口后,复跑桌面 build/typecheck/lint、2351 项桌面测试和跨进程 E2E 通过。ARCHITECTURE_BASE=7c0710fc38437725bd432d86ab4be05159ebd522 node scripts/check-architecture.mjs通过,主入口 1499/1500 行。--testTimeout 15000)。node scripts/e2e-rpc-unicode.mjs通过:真实 Host/Sidecar 的写入、重启恢复、流式消息和后续请求。限制
subagent-fallback.test.ts的双模型 HTTP 429 重试用例超时;未修改的基线也复现同一失败。未将默认测试命令标为全绿。Fixes #597