Repository navigation
feat(jev): support custom System One endpoints - #1738
Open
AuhNijGnahz wants to merge 2 commits into
Open
AuhNijGnahz wants to merge 2 commits into
AuhNijGnahz wants to merge 2 commits into
Conversation
Allow Jev to bind to a user-configured System One endpoint and model while preserving the official TypeSafe default for existing installations. Keep classifier setup isolated from chat providers and enforce probe-before-save plus endpoint safety.
Update the endpoint-adoption regression contract for the System One setup guard so classifier configuration cannot consume chat discovery results.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jev-latestas the legacy defaultCompatibility and security
jevEnabledplussecret:app:typesafe-jevkeep the official TypeSafe behaviorjevApiKeyruntime input remain supported as official-default compatibility paths/systemoneinputs normalize to one operation URL;/systemoneis appended exactly oncebaseUrlandmodelIdare persisted in settingsValidation
Task candidate:
c5ff001d7e8467bb36439ed0aa876450c1e6c279Base main:
e219a3e4c0e4cc73ddacde78005987a85d5977d6Passed:
pnpm build:jspnpm --filter @pi-desktop/desktop typecheckpnpm --filter @pi-desktop/shared test— 100 files / 1,282 testspnpm lintpnpm test:e2e:jev— 21 Desktop tests plus 7 Agent Runtime Jev testspnpm test:e2e:provider-api-style— 26 scenarios; run twice after stabilizing observable UI synchronizationcargo test -p host-core --locked rpc::tests::jev_classifier_binding_round_trips_clears_and_validates -- --exactcargo clippy -p host-core --all-targets --locked(one pre-existing warning intranscripts.rs)cargo fmt --checkgit diff --checkpnpm check:pr-baseAdditional broad suites attempted on Windows:
EPERM), shell/SSH fixture execution, macOS-only shell-path assumptions, and existing catalog-value baselines. The Jev Electron path emitted all expectedtrueassertions but its child process was signalled after reporting under full-suite contention; the same path passes in the dedicated Jev E2E suite.No real TypeSafe/OpenRouter key, paid API, or live provider endpoint was used.