Repository navigation
feat(composer): open the mode menu instead of cycling the chip - #1737
Merged
Merged
Conversation
The chip painted its icon and reasoning level in the accent colour while the model name stayed secondary, so the brightest thing in the row was the metadata rather than the selection. The mid-dot separator plus the chevron also crowded four glyph clusters into a 26px pill that sat a couple of pixels shorter than every neighbouring control. Give the row one lead: the model name takes primary ink at medium weight, the reasoning level becomes a tonal badge, and icon and chevron stay muted until hover. Dropping the separator removes the extra element, and inheriting the shared 28px control height lines the chip up with the rest of the composer toolbar. The subagent transcript picker reuses the same classes, so it is fixed by the same rules.
The reasoning ladder under the model menu is six stops wide inside 268px of panel, so the active "medium" label ellipsized to "medi…" and the panel read as broken rather than tight. The chip also carried a bot glyph that only repeated the model name next to it. It now appears only at the 450px floor, where the chip drops its labels and needs a glyph to stay a recognizable trigger; the reasoning level reads as a tonal badge instead of accent-coloured text.
… menus The mode chip advanced one state per click, so reaching Goal from Agent took two clicks and no surface showed all three modes at once. The approval chip opened a 120px menu for three short options. Both kept the user aiming at a target they could not see. Composer-left now holds one segmented cluster: Agent/Plan/Goal and Ask/Accept edits/Auto, each option a real radio target one click away. The committed option keeps its name on a raised plate while the others stay glyphs with their names on hover, so the cluster reads at rest without widening the toolbar. Arrow keys move and commit, Home/End jump to the ends, and Goal locks the approval group to Auto with the reason in its accessible name. Scheduled task drafts reuse the same approval switch.
Composer modes and approval levels returned to two chips. The always-visible segmented row answered a click-count complaint but spent too much toolbar width; the replacement is a pair of menus rather than a wide cluster.
The mode chip advanced one state per click, so reaching Goal from Agent took two clicks and the other modes were never on screen. A row of three always-visible options removed the clicks but cost roughly 70px of toolbar per state, crowding the approval control next to it. The chip now keeps naming only the committed mode and opens one menu whose three rows are radio menu items with the committed mode checked; picking a row closes the menu and configures the active session. The fixed width grows from 88px to 96px to cover the caret, and opening either this menu or the approval menu closes the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更
说明
本地 main 上积累的 composer/侧边栏未推送提交，合入远端 main。
验证
未在本分支额外执行 typecheck/lint/测试，依赖仓库 CI 门禁。