Repository navigation
fix(sidebar): refine session rows and todo disclosure - #1734
Merged
Merged
Conversation
Keep each project session date and overflow action in one stable trailing slot so hover and keyboard focus switch between them without shifting the row. Use month and day for older activity dates to keep the sidebar metadata compact.
Use a 36px square disclosure target and size its arrow to 18px. The shared button padding previously squeezed the larger icon, so give the composed button selector its own zero-padding rule. Seed the existing Session time preference in sidebar coverage so the new row-date behavior is exercised under its enabled setting.
Keep the translated UX references aligned with the new session-date slot and the TodoDock disclosure dimensions. This also preserves the English/Chinese table shape required by the docs locale gate.
Match keyboard and touch assertions to the shared session metadata slot. The date/action layout moved out of the former row-actions wrapper, so the tests should cover the current focus and no-hover selectors.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm build:jspnpm build:hostpnpm --filter @pi-desktop/desktop typecheckpnpm lintpnpm test:e2e:todospnpm test:e2e:layout(201/201)