Repository navigation
fix(chat): close nested-list streaming cursor reflow - #1373
Merged
Merged
Conversation
Prevent vertical layout jumping and reflow during assistant stream rendering by keeping the smooth-stream cursor active throughout active streaming, positioning the cursor inline at leaf elements and list items rather than container lists, and disabling orphan-rebalancing line wrapping during active streams. Fixes #1345
…ed-streaming-cursor
The generic last-child cursor selector can still append an inline box to a nested ul or ol inside the final list item. Restrict list and quote cursors to terminal paragraphs or text leaves so nested containers do not gain a trailing line during streaming.
…ed-streaming-cursor
…ed-streaming-cursor
…ed-streaming-cursor
…ed-streaming-cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up carries the original #1362 change and fixes the remaining nested-list cursor case.
The original selector can still put
::afteron a nested list container when the final outer list item ends with another list. That creates the same extra inline line box the PR is intended to remove. This change anchors list and quote cursors to terminal paragraphs or text leaves, adds a regression assertion for the broad selector, and records the nested-list layout expectation in the UX and E2E specs.Validation:
node --test apps/desktop/test/chat-streaming-layout.test.mjspassed (3 tests).git diff --checkpassed.origin/mainis an ancestor of this head; latest base is included.verify:ui:*; the existing test is a source-level regression test.Supersedes #1362. Fixes #1345.