Repository navigation
Conversation
…ing) The settings-scroll E2E has been unrunnable since the live-voice worklet landed: its bare-esbuild bundle chokes on the ?url import in live-call-controller.ts. Add the same local-url-assets plugin the other E2E bundles (composer-paste, transcript-render) already use. After unblocking the build, the fixture's import.meta.env.DEV=false define hides developmentOnly settings surfaces (Cloud sync) even with developer mode on, failing the must-appear assertion. Run the fixture with DEV semantics, matching how those surfaces are gated; the developer-only gate (absent without developer mode) is unchanged and still asserted. Verified locally: SETTINGS_SCROLL ok:true with light/dark themes, update preference, and pt-BR locale checks passing.
4305aa6 to
9aff77e
Compare
|
Thanks for finding both breakages in the settings-scroll fixture and documenting the failure sequence. Your |
|
Superseded by merged PR #1354. |
|
Thank you for the careful handoff — and apologies for the late acknowledgment on our side. Two things worth recording from your note:
|
Summary
The
settings-scrollE2E has been unrunnable onmainsince 2026-09-28, due to two independent breakages stacked on top of each other (invisible to CI because E2E scripts are not in the gate set):Build failure since
ef9aae83a(live voice sessions):live-call-controller.tsimports./pcm-worklet.js?url, which the script's bare-esbuild bundle cannot resolve —No matching export in "…/pcm-worklet.js?url" for import "default". This adds the samelocal-url-assetsplugin thate2e-composer-paste.mjs,e2e-transcript-render.mjsand friends already use.Assertion failure since
07bc80261(expose Live Voice to regular users): thedevelopmentOnlynav gating (settings-search.ts) hides thesync(Cloud sync) destination even with developer mode on, because the fixture definesimport.meta.env.DEV: "false"(packaged semantics) — soincludeDevelopmentOnly=false(SettingsPage.tsx:94) and the "Cloud sync must appear in settings search with developer mode" check can never pass. The fixture now runs with DEV semantics, matching how those surfaces are gated in a dev build; thedeveloperOnlygate (absent without developer mode) is unchanged and still asserted.Verification
?urlerror (exit 1).SETTINGS_SCROLL {"ok":true, …}— light/dark themes, update preference, and pt-BR locale checks all pass, against a real host binary (PI_DESKTOP_HOST_BINinjected release build).