Skip to content

Fix point calculation on group winner update by api #patch #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanalmsick merged 4 commits into from
Jun 28, 2026
Merged

Fix point calculation on group winner update by api #patch #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebd9b50
Auto-merge main back to dev after PR #54
actions-user Jun 28, 2026
c008896
dependabot chore (deps): bump the npm-minor-patch group
dependabot[bot] Jun 28, 2026
9fb56fd
Fix calculate points if group winners are updated by api #patch
vanalmsick Jun 28, 2026
f4bfc50
Merge pull request #55 from vanalmsick/dependabot/npm_and_yarn/fronte…
vanalmsick Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backend/src/api_football_data/football_data_org.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,8 @@ async def update_ranking(db: AsyncSession, tournament: Tournament, force_refresh
if not force_refresh and hash_file.is_file() and hash_file.read_text().strip() == data_hash:
logger.info(f"No ranking changes detected for tournament {tournament.id} — skipping update.")
return

groups_recalculate_points = []

for fd_standing in fd_standings:
group_name = transform_name(fd_standing["group"])
Expand Down Expand Up @@ -288,9 +290,13 @@ async def update_ranking(db: AsyncSession, tournament: Tournament, force_refresh

matched_group.winner_team_id = winning_team_id
logger.info(f"Set winner of group '{group_name}' for tournament '{tournament.name}' ({tournament.id}) to team ID {winning_team_id}.")
groups_recalculate_points.append(matched_group.id)

await db.commit()

for group_id in groups_recalculate_points:
await predictions_scoring.recalculate_group_points(db, group_id)

hash_file.write_text(data_hash)


Expand Down
89 changes: 46 additions & 43 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"@reduxjs/toolkit": "^2.12.0",
"@sentry/react": "^10.56.0",
"@sentry/react": "^10.57.0",
"lucide-react": "^1.17.0",
"react": "^19.2.7",
"react-dom": "^19.2.7",
Expand All @@ -21,11 +21,11 @@
"devDependencies": {
"@eslint/js": "^10.0.1",
"@tailwindcss/postcss": "^4.3.1",
"@types/react": "^19.2.16",
"@types/react": "^19.2.17",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.2",
"autoprefixer": "^10.4.20",
"eslint": "^10.4.1",
"eslint": "^10.5.0",
"eslint-plugin-react-hooks": "^7.1.1",
"eslint-plugin-react-refresh": "^0.5.3",
"globals": "^17.6.0",
Expand Down
Loading