Open
Conversation
Signed-off-by: Pari Mohite <parimoh@amazon.com>
Signed-off-by: Pari Mohite <parimoh@amazon.com>
roshkhatri
reviewed
Aug 8, 2025
Comment on lines
+165
to
+166
| printf '#!/bin/sh\nset -e\nif [ $# -ne 2 ]; then\n echo "Usage: make-ssl-cert <cert_file> <key_file>" >&2\n exit 1\nfi\nmkdir -p "$(dirname "$1")" "$(dirname "$2")"\nopenssl req -new -x509 -days 3650 -nodes -out "$1" -keyout "$2" -subj "/CN=localhost"\n' > /usr/local/bin/make-ssl-cert; \ | ||
| chmod +x /usr/local/bin/make-ssl-cert |
Member
There was a problem hiding this comment.
Can we make this script like entrypoint.sh and copy it to the image??
We are essentially creating it on runtime here
Member
|
Also can we add tests for these? |
Signed-off-by: Pari Mohite <parimoh@amazon.com>
Signed-off-by: Pari Mohite <parimoh@amazon.com>
Signed-off-by: Pari Mohite <parimoh@amazon.com>
Signed-off-by: Pari Mohite <parimoh@amazon.com>
Signed-off-by: Pari Mohite <parimoh@amazon.com>
Signed-off-by: Pari Mohite <parimoh@amazon.com>
Signed-off-by: Pari Mohite <parimoh@amazon.com>
|
@roshkhatri @Nikhil-Manglore is this something we still need or should be prioritised? |
Member
|
This doesn't need to be prioritized, I will have to read up on snake oil certificates before I can review this and see if we need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to address #54. I'm gonna test this / research a bit more on this as well just to make sure that it actually works as intended and does everything it's supposed to.
Summary
Adds make-ssl-cert functionality to both Debian and Alpine variants for generating self-signed certificates which allows for SSL/TLS testing capabilities.
Changes Made
Debian Images:
Alpine Images:
Usage Examples
Debian:
docker run --rm valkey:debian make-ssl-cert generate-default-snakeoilAlpine:
docker run --rm valkey:alpine make-ssl-cert /tmp/cert.pem /tmp/key.pemTesting
Size Impact